[PATCH] ath10k: don't drop corrupted mgmt frames

[Michal Kazior]

On 25 November 2014 at 10:04, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
[...]
>> @@ -1394,12 +1396,19 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>>               return false;
>>       }
>>
>> +     is_mgmt = !!(rxd->attention.flags &
>> +                  __cpu_to_le32(RX_ATTENTION_FLAGS_MGMT_TYPE));
>> +     has_fcs_err = !!(rxd->attention.flags &
>> +                      __cpu_to_le32(RX_ATTENTION_FLAGS_FCS_ERR));
>
> I think I asked this before in some other patch, but isn't '!!' operator
> useless here? is_mgmt is a boolean so the compiler should convert it
> correctly without '!!' anyway, right?

If I remove `!!` I get:

 warning: incorrect type in assignment (different base types)
    expected bool [unsigned] [usertype] is_mgmt
    got restricted __le32

I could do a temporary `u32 attention` to get rid of the `!!`. You
want me to update it?


Michał