[PATCH 4/7] ath10k: unify rx undecapping

Michal Kazior michal.kazior at tieto.com
Mon Nov 17 22:46:35 PST 2014


On 17 November 2014 16:11, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>> On 17 November 2014 15:32, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
[...]
>>> This patch had few checkpatch warnings. I fixed them with the folded
>>> patch and full patch here:
>>>
>>> https://github.com/kvalo/ath/commit/71fbd07d43e54f5f9f442bc5f2f4f9ef83aead63
[...]
>>> @@ -1132,7 +1133,7 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
>>>         bool has_fcs_err;
>>>         bool has_crypto_err;
>>>         bool has_tkip_err;
>>> -       bool has_peer_idx_invalid;
>>> +       bool has_idx_invalid;
>>>         bool is_decrypted;
>>
>> I don't really like the has_idx_invalid. Perhaps has_peer_err conveys
>> a bit more of the original meaning?
>
> What about just peer_idx_invalid? IMHO we really don't need the has_
> prefix in that relatively small function.

Good point but the assignment line with `peer_idx_invalid` will still
be over 80 chars long, no?

So perhaps instead of doing `rxd->attention.flags &
__cpu_to_le32(FLAG)` it could be `attention =
__le32_to_cpu(rxd->attention.flags)` and then `attention & FLAG` ?
This way it shouldn't exceed the 80 char limit and var names won't
need to be changed. Hopefully compiler will optimize it away.


Michał



More information about the ath10k mailing list