[PATCH v2] ath10k: handle ieee80211 header and payload tracing separately

Rajkumar Manoharan rmanohar at qti.qualcomm.com
Wed Nov 5 02:44:59 PST 2014


On Wed, Nov 05, 2014 at 11:12:01AM +0100, Johannes Berg wrote:
> On Wed, 2014-11-05 at 15:14 +0530, Rajkumar Manoharan wrote:
> 
> > The macro is defined to ease readability and reduce # of line changes.
> > I originally thought of naming the macro as IEEE80211_HDR_LEN. But such
> > definition does not look correct inside driver.
> 
> FWIW, I pointed Kalle to the macro on IRC - IMHO you should pass
> arguments to the macro (and probably even make it an inline function)
> rather than having it assume certain variables exist when the macro is
> used.
> 
> Kalle may have misunderstood what I was trying to say :)
> 
Sounds clear..Thanks for pointing out. Will change it as inline funtion..

-Rajkumar



More information about the ath10k mailing list