[PATCH 4/4 v2] ath10k: invalid msdu-id logging

Kalle Valo kvalo at qca.qualcomm.com
Tue Mar 25 08:02:11 EDT 2014


greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
>
> Make this message more obvious that it is a serious
> problem (will cause tx flush issues, at least).
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>
> ---
>
> v2:  Add this to series, but ordering is not overly important.
>

[...]

> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>  		   tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>  
>  	if (tx_done->msdu_id >= htt->max_num_pending_tx) {
> -		ath10k_warn("warning: msdu_id %d too big, ignoring\n",
> +		ath10k_warn("error: msdu_id %d too big, ignoring\n",
>  			    tx_done->msdu_id);
>  		return;
>  	}

To me any warning is a serious matter, I'm not sure how changing this to
message to use "error:" makes any difference?

-- 
Kalle Valo



More information about the ath10k mailing list