[PATCH 3/3] ath10k: add otp and firmware boot error messages.
Kalle Valo
kvalo at qca.qualcomm.com
Mon Mar 24 07:25:09 EDT 2014
greearb at candelatech.com writes:
> From: Ben Greear <greearb at candelatech.com>
>
> If OTP or firmware fails to load properly, print out some
> extra info in the kernel logs.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>
[...]
> @@ -597,12 +598,16 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
> return ret;
>
> ret = ath10k_download_and_run_otp(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot otp execute result %d\n", ret);
> return ret;
> + }
"failed to run otp: %d\n"
> ret = ath10k_download_fw(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot download firmware result %d\n", ret);
> return ret;
> + }
"failed to download firmware: %d\n"
And I think you should add the same for ath10k_download_board_data()
call before these two, it neither prints anything when an error happens.
--
Kalle Valo
More information about the ath10k
mailing list