[PATCH 1/4] ath10k: provide firmware crash info via debugfs.

Kalle Valo kvalo at qca.qualcomm.com
Sun Jun 8 01:12:28 PDT 2014

Ben Greear <greearb at candelatech.com> writes:

>>>> Instead of doing atomic allocations multiple times in a loop, would it
>>>> be better to allocate just one buffer before the loop and free it
>>>> afterwards?
>>> There is no hard guarantee that the buffer lengths are the same,
>>> so I think it needs to remain as is.  Would rather not crap out
>>> because firmware suddenly got more clever...
>> This is related to my earlier comment about having a max len for the
>> buffers. So why not come up with a sane max length, allocate once a
>> temporary buffer of that length and use the same buffer in the loop?
> I can fix it at a 4k chunk if you want.  Current firmware uses around 2k chunk
> I believe, and only two buffers, so either way it's not a lot of work for CPU.

I think we should have a max chunk size in ath10k anyway and using one
buffer makes sense in that case.

Kalle Valo

More information about the ath10k mailing list