[PATCH 1/4] ath10k: provide firmware crash info via debugfs.

Ben Greear greearb at candelatech.com
Fri Jun 6 10:06:35 PDT 2014

On 06/06/2014 02:33 AM, Kalle Valo wrote:

>> +					kfree(buffer);
>> +					goto save_regs_and_restart;
>> +				}
>> +
>> +				ath10k_dbg_save_fw_dbg_buffer(ar, buffer,
>> +							      dbuf.length);
>> +				kfree(buffer);
> Instead of doing atomic allocations multiple times in a loop, would it
> be better to allocate just one buffer before the loop and free it
> afterwards?

There is no hard guarantee that the buffer lengths are the same,
so I think it needs to remain as is.  Would rather not crap out
because firmware suddenly got more clever...


Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

More information about the ath10k mailing list