[PATCH v2] ath10k: fix the MAC address of peer statistic
Kalle Valo
kvalo at qca.qualcomm.com
Fri Jan 17 08:40:41 EST 2014
Michal Kazior <michal.kazior at tieto.com> writes:
> On 10 January 2014 10:19, Chun-Yeow Yeoh <yeohchunyeow at gmail.com> wrote:
>
>> struct wmi_peer_stats {
>> + __le32 peer_tx_rate; /* TBA */
>> struct wmi_mac_addr peer_macaddr;
>> __le32 peer_rssi;
>> - __le32 peer_tx_rate;
>> } __packed;
>
> This looks wrong too. I've just checked it and it seems the
> `wal_dbg_tx_stats` is out of date. It's missing a `__le32
> stateless_tid_alloc_failure` that has been inserted at some point in
> time in the firmware between `pdev_resets` and `phy_underrun`. You
> should add this missing field instead of moving `peer_tx_rate`.
>
> Unfortunately AP firmware has even more fields inserted in
> `wmi_pdev_stats`. Making this work with both firmwares is a mess.
This reminds me that Bartosz sent something related to this few months back:
http://lists.infradead.org/pipermail/ath10k/2013-September/000317.html
I promised to finish it, but it's still in my todo folder :/
--
Kalle Valo
More information about the ath10k
mailing list