[PATCH v2] ath10k: support msdu chaining.

Kalle Valo kvalo at qca.qualcomm.com
Fri Feb 28 02:38:41 EST 2014

greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
> Consolidate the list of msdu skbs into the msdu-head skb, delete the
> rest of the skbs, pass the msdu-head skb on up the stack as normal.
> Tested with high-speed TCP and UDP traffic on modified firmware that
> supports raw-rx.
> Signed-off-by: Ben Greear <greearb at candelatech.com>
> ---
> v2:  Add note about skb_try_coalesce, though I am not sure it will
>      work or not.
>      Only grow skb once, which should save on some memory (re)allocation
>      and copying when we have more than one chained skb.

I didn't look at the patch itself yet, but I see checkpatch warnings:

drivers/net/wireless/ath/ath10k/htt_rx.c:1022: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1032: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1044: WARNING: labels should not be indented
drivers/net/wireless/ath/ath10k/htt_rx.c:1053: WARNING: labels should not be indented

Kalle Valo

More information about the ath10k mailing list