[PATCH 1/2] ath10k: add vdev-id, return code to error codes

Ben Greear greearb at candelatech.com
Fri Feb 14 10:33:58 EST 2014

On 02/13/2014 10:06 PM, Kalle Valo wrote:

> @@ -1542,20 +1542,20 @@ static int ath10k_station_assoc(struct ath10k *ar, struct ath10k_vif *arvif,
>   	ret = ath10k_setup_peer_smps(ar, arvif, sta->addr, &sta->ht_cap);
>   	if (ret) {
> -		ath10k_warn("failed to setup peer SMPS: %d\n", ret);
> +		ath10k_warn("failed to setup peer SMPS for vdev: %d\n", ret);
>   		return ret;
>   	}

Looks like that could use the vdev id in it...I must have missed it on my first attempt.

> @@ -3252,7 +3252,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
>   			   arvif->vdev_id, sta->addr);
>   		ret = ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
>   		if (ret)
> -			ath10k_warn("Failed to delete peer: %pM for VDEV: %d ret %i\n",
> +			ath10k_warn("Failed to delete peer %pM for vdev %d: %i\n",
>   				    sta->addr, arvif->vdev_id, ret);

While you are harmonizing the messages...maybe change all instances of "failed to "Failed ?

I wasn't sure what was preferred so I left that alone when doing my patch.

The rest of the changes look fine to me.


Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

More information about the ath10k mailing list