[RFC] wmi: Handle failure to start scan.

Kalle Valo kvalo at qca.qualcomm.com
Fri Feb 14 01:13:25 EST 2014


greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
>
> Properly clean up driver state in case firmware fails
> to start scan for some reason.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>

Why just RFC?

And "ath10k:" prefix missing.

> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -770,7 +770,25 @@ static int ath10k_wmi_event_scan(struct ath10k *ar, struct sk_buff *skb)
>  		ath10k_dbg(ATH10K_DBG_WMI, "WMI_SCAN_EVENT_PREEMPTED\n");
>  		break;
>  	case WMI_SCAN_EVENT_START_FAILED:
> -		ath10k_dbg(ATH10K_DBG_WMI, "WMI_SCAN_EVENT_START_FAILED\n");
> +		ath10k_warn("WMI_SCAN_EVENT_START_FAILED, reason: %i\n", reason);

"scan failed to start: %i\n"

> +		ar->scan_channel = NULL;
> +		if (!ar->scan.in_progress) {
> +			ath10k_warn("scan-start-failed: no scan requested, ignoring\n");

"scan failed to start but no scan requested, ignoring\n"

-- 
Kalle Valo



More information about the ath10k mailing list