[PATCH 4/4] ath10k: Better tx/rx debugging.

[Kalle Valo]

Marek Puzyniak <marek.puzyniak at tieto.com> writes:

> On 4 February 2014 19:55, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> greearb at candelatech.com writes:
>>
>>> From: Ben Greear <greearb at candelatech.com>
>>>
>>> Make it easier to grep for htt rx errors.
>>>
>>> Signed-off-by: Ben Greear <greearb at candelatech.com>
>>
>> [...]
>>
>>> @@ -961,6 +962,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>>>                       }
>>>
>>>                       if (test_bit(ATH10K_CAC_RUNNING, &htt->ar->dev_flags)) {
>>> +                             ath10k_warn("htt rx: CAC running\n");
>>>                               ath10k_htt_rx_free_msdu_chain(msdu_head);
>>>                               continue;
>>>                       }
>>
>> I'm a bit worried about this one. Do we guarantee that we will never
>> receive frames while CAC is running? In other words, is this a normal
>> event or really an error in the driver which requires a warning
>> message?
>
> Actually this happens quite often during CAC. I remember we had some
> print there and we got it frequently (let say 10/s).

Yeah, this was exactly what I was wondering.

> So probably it would be better to have choice to enable this log print
> when someone need this information otherwise by default it should be
> disabled.

Maybe a debug message is better?

-- 
Kalle Valo