[PATCH 1/4] ath10k: Print out firmware feature bits from IE.

[Kalle Valo]

greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
>
> Aids in understanding excactly what a firmware is
> offering.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>

Patch 1 applied, still reviewing the rest.

> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -470,8 +470,12 @@ static int ath10k_core_fetch_firmware_api_n(struct ath10k *ar, const char *name)
>  				if (index == ie_len)
>  					break;
>  
> -				if (data[index] & (1 << bit))
> +				if (data[index] & (1 << bit)) {
> +					ath10k_dbg(ATH10K_DBG_BOOT,
> +						   "Enabling feature bit: %i\n",
> +						   i);
>  					__set_bit(i, ar->fw_features);
> +				}
>  			}

I was actually hoping to have something better like ath6kl has which
prints a name for the feature:

	{ ATH6KL_FW_CAPABILITY_HOST_P2P, "host-p2p" },
	{ ATH6KL_FW_CAPABILITY_SCHED_SCAN, "sched-scan" },
	{ ATH6KL_FW_CAPABILITY_STA_P2PDEV_DUPLEX, "sta-p2pdev-duplex" },
	{ ATH6KL_FW_CAPABILITY_INACTIVITY_TIMEOUT, "inactivity-timeout" },
	{ ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE, "rsn-cap-override" },
	{ ATH6KL_FW_CAPABILITY_WOW_MULTICAST_FILTER, "wow-mc-filter" },

But this is something for the future.

-- 
Kalle Valo