[PATCH v4 8/8] ath10k: implement wmi-tlv backend

[Kalle Valo]

Michal Kazior <michal.kazior at tieto.com> writes:

> On 3 December 2014 at 09:11, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> [...]
>> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
>> index 0f4369e4f358..815d6e27aa53 100644
>> --- a/drivers/net/wireless/ath/ath10k/core.c
>> +++ b/drivers/net/wireless/ath/ath10k/core.c
>> @@ -844,6 +844,10 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar)
>>                 ar->max_num_stations = TARGET_10X_NUM_STATIONS;
>>                 ar->htt.max_num_pending_tx = TARGET_10X_NUM_MSDU_DESC;
>>                 break;
>> +       case ATH10K_FW_WMI_OP_VERSION_TLV:
>> +               ar->max_num_peers = TARGET_TLV_NUM_PEERS;
>> +               ar->max_num_stations = TARGET_TLV_NUM_STATIONS;
>> +               ar->htt.max_num_pending_tx = TARGET_TLV_NUM_MSDU_DESC;
>
> Missing break?

Fixed by folding this:

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 5b33f01fcee5..577a3d76df22 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -919,6 +919,7 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar)
                ar->max_num_peers = TARGET_TLV_NUM_PEERS;
                ar->max_num_stations = TARGET_TLV_NUM_STATIONS;
                ar->htt.max_num_pending_tx = TARGET_TLV_NUM_MSDU_DESC;
+               break;
        case ATH10K_FW_WMI_OP_VERSION_UNSET:
        case ATH10K_FW_WMI_OP_VERSION_MAX:
                WARN_ON(1);


-- 
Kalle Valo