[PATCH] ath10k: add error handling to ath10k_pci_wait()

Kalle Valo kvalo at qca.qualcomm.com
Mon Oct 21 10:19:02 EDT 2013


Kalle Valo <kvalo at qca.qualcomm.com> writes:

> ath10k_pci_wait() didn't notify any errors to callers, it
> just printed a warning so add proper error handling.
>
> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>

Applied, I just changed the commit log to this:

commit f3782744c9b50edf94d28e37a937ff84f267dfab
Author: Kalle Valo <kvalo at qca.qualcomm.com>
Date:   Thu Oct 17 11:36:15 2013 +0300

    ath10k: add error handling to ath10k_pci_wait()
    
    ath10k_pci_wait() didn't notify any errors to callers, it
    just printed a warning so add proper error handling. This fixes
    a crash Ben reported:
    
    ath10k: MSI-X interrupt handling (8 intrs)
    ath10k: Unable to wakeup target
    ath10k: target took longer 5000 us to wake up (awake count 1)
    ath10k: Failed to get pcie state addr: -16
    ath10k: early firmware event indicated
    BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
    IP: [<ffffffffa06ae46c>] ath10k_ce_completed_send_next+0x47/0x122 [ath10k_pci]
    
    Reported-by: Ben Greear <greearb at candelatech.com>
    Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>

-- 
Kalle Valo



More information about the ath10k mailing list