[PATCH 3/7] ath10k: track vif list internally

Kalle Valo kvalo at qca.qualcomm.com
Wed Oct 16 08:47:15 EDT 2013


Michal Kazior <michal.kazior at tieto.com> writes:

> On 15 October 2013 11:49, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> Kalle Valo <kvalo at qca.qualcomm.com> writes:
>>
>>> From: Michal Kazior <michal.kazior at tieto.com>
>>>
>>> mac80211 interface interations functions have
>>> peculiar locking issues. This patch introduces
>>> internal (to ath10k) vif list that will be used
>>> for vif iteration purposes.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
>>> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
>>
>> [...]
>>
>> Michal, why do the INIT_LIST_HEAD() twice? Isn't it enough to do it
>> core_start()?
>
> Ah, good point. It's most likely okay to just do it in
> ath10k_core_start(). The one in ath10k_core_create() isn't required.

Ok, I removed the one from ath10k_core_create() before I commited this.

-- 
Kalle Valo



More information about the ath10k mailing list