[PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN
Julia Lawall
julia.lawall at lip6.fr
Thu Oct 3 01:47:49 EDT 2013
On Wed, 2 Oct 2013, Joe Perches wrote:
> On Wed, 2013-10-02 at 22:24 -0700, Eric Dumazet wrote:
> > On Wed, 2013-10-02 at 22:09 -0700, Joe Perches wrote:
> > > On Wed, 2013-10-02 at 21:44 -0700, Eric Dumazet wrote:
> > > > I mean the 6, of course, since Joe seems to actively track them, as if
> > > > ETH_ALEN could change eventually, you never know.
> > >
> > > You're funny Eric.
> > > You know it's just to ease grep pattern matching.
> >
> > You are not funny if you plan to send 500+ patches for every instance of
> > 6 changed to ETH_ALEN
>
> You're still funny.
>
> https://lkml.org/lkml/2013/10/1/517
>
> Lighten up though. It was just a straggler.
Actually, the few cases that I looked up by hand seemed to use 6
consistently for the declaration and the memcpy/memset. So it would be
nicer to fix them all at once.
At least in drivers/net there are around 40, not 500.
julia
More information about the ath10k
mailing list