[PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN
Kalle Valo
kvalo at qca.qualcomm.com
Thu Oct 3 00:54:39 EDT 2013
Eric Dumazet <eric.dumazet at gmail.com> writes:
> On Thu, 2013-10-03 at 07:34 +0300, Kalle Valo wrote:
>
>> Do you mean '6' or the union? The 6 can replaced with ETH_ALEN AFAICS.
>> But the union is needed for aligning the packets as firmware expects
>> them.
>
> I mean the 6, of course, since Joe seems to actively track them, as if
> ETH_ALEN could change eventually, you never know.
>
> I am worrying this will take another hundred patches ...
Ah, ok.
> Regarding this union, the __packed attributes seem overkill, no ???
Yeah, they do. This should be enough, right?
struct wmi_mac_addr {
union {
u8 addr[6];
struct {
u32 word0;
u32 word1;
};
};
} __packed;
--
Kalle Valo
More information about the ath10k
mailing list