What to do about hung firmware?

[Kalle Valo]

Ben Greear <greearb at candelatech.com> writes:

> On 11/05/2013 11:46 PM, Kalle Valo wrote:
>> Michal Kazior <michal.kazior at tieto.com> writes:
>> 
>>> You probably could try WMI_ECHO_CMDID to implement a keep alive when
>>> idling (i.e. not sending WMI commands for a few seconds at least).
>> 
>> Sending something periodically would be bad from power consumption point
>> of view. We would need to either disable it by default, only send it if
>> there's a problem or something like that.
>
> Ok, how about this:
>
> If we hit the 3*HZ timeout, then we send a ping to the firmware
> even if we are out of tickets.
>
> If we get no response to that in 3*HZ or so, then consider firmware
> hung and reset it.

Sounds good to me.

-- 
Kalle Valo