[PATCH v2 1/6] ath10k: use inline ce_state structure

Kalle Valo kvalo at qca.qualcomm.com
Wed Aug 28 00:12:33 EDT 2013


Michal Kazior <michal.kazior at tieto.com> writes:

> Simplifies memory managament of ce_state.
>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

Sorry, I noticed this only in my second review round:

> --- a/drivers/net/wireless/ath/ath10k/pci.h
> +++ b/drivers/net/wireless/ath/ath10k/pci.h
> @@ -233,7 +233,10 @@ struct ath10k_pci {
>  	spinlock_t ce_lock;
>  
>  	/* Map CE id to ce_state */
> -	struct ce_state *ce_id_to_state[CE_COUNT_MAX];
> +	struct ce_state ce_states[CE_COUNT_MAX];
> +
> +	/* makes sure that dummy reads are atomic */
> +	spinlock_t hw_v1_workaround_lock;
>  };

That lock doesn't look right. Is it a leftover from a rebase?

-- 
Kalle Valo



More information about the ath10k mailing list