[PATCH v2 2/3] wifi: wcn36xx: Do not enforce interrupt trigger type
Alexandre Rapaille via B4 Relay
devnull+arapaille.atlr-engineering.com at kernel.org
Fri Nov 20 00:05:46 PST 2026
From: Alexandre Rapaille <arapaille at atlr-engineering.com>
request_irq() with IRQF_TRIGGER_HIGH stores level on the IRQ mapping,
which outlives the driver, so a DT with another type gets "type
mismatch" and -ENXIO on the next probe. Rely on the DT as ath10k does;
every in-tree qcom,wcnss-wlan node is level high (msm8974 since the
previous patch).
Signed-off-by: Alexandre Rapaille <arapaille at atlr-engineering.com>
---
drivers/net/wireless/ath/wcn36xx/dxe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c
index 801f1218ef..7852f71368 100644
--- a/drivers/net/wireless/ath/wcn36xx/dxe.c
+++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
@@ -552,14 +552,14 @@ static int wcn36xx_dxe_request_irqs(struct wcn36xx *wcn)
{
int ret;
- ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete,
- IRQF_TRIGGER_HIGH, "wcn36xx_tx", wcn);
+ ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete, 0,
+ "wcn36xx_tx", wcn);
if (ret) {
wcn36xx_err("failed to alloc tx irq\n");
goto out_err;
}
- ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, IRQF_TRIGGER_HIGH,
+ ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, 0,
"wcn36xx_rx", wcn);
if (ret) {
wcn36xx_err("failed to alloc rx irq\n");
--
2.43.0
More information about the wcn36xx
mailing list