[PATCH v2] wcn36xx: Add RX frame SNR as a source of system entropy

Bryan O'Donoghue bryan.odonoghue at linaro.org
Wed Sep 14 17:14:08 PDT 2022


On 15/09/2022 00:57, Jason A. Donenfeld wrote:
> Won't this break on big endian? Just have an assignment handle it:
> 

Yes but these SoCs are all LE

>      u8 snr_sample = snr & 0xff;
>      add_device_randomness(&snr_sample, sizeof(snr_sample);
> 
> That & 0xff is redundant, but it doesn't hurt to be explicit.

Sure NP I'll v3 it.

---
bod



More information about the wcn36xx mailing list