[PATCH 3/3] wcn36xx: Implement downstream compliant beacon filtering
Bryan O'Donoghue
pure.logic at nexus-software.ie
Mon Dec 13 06:37:33 PST 2021
On 13/12/2021 13:51, Bryan O'Donoghue wrote:
> Downstream facilitates the direct programming of beacon filter tables via
> SMD commands.
>
> The purpose of beacon filters is quote:
>
> /* When beacon filtering is enabled, firmware will
> * analyze the selected beacons received during BMPS,
> * and monitor any changes in the IEs as listed below.
> * The format of the table is:
> * - EID
> * - Check for IE presence
> * - Byte offset
> * - Byte value
> * - Bit Mask
> * - Byte reference
> */
>
> The default downstream firmware filter table looks something like this:
> tBeaconFilterIe gaBcnFilterTable[12] =
> {
> { WLAN_EID_DS_PARAMS, 0u, { 0u, 0u, 0u, 0u } },
> { WLAN_EID_ERP_INFO, 0u, { 0u, 0u, 248u, 0u } },
> { WLAN_EID_EDCA_PARAM_SET, 0u, { 0u, 0u, 240u, 0u } },
> { WLAN_EID_QOS_CAPA, 0u, { 0u, 0u, 240u, 0u } },
> { WLAN_EID_CHANNEL_SWITCH, 1u, { 0u, 0u, 0u, 0u } },
> { WLAN_EID_QUIET, 1u, { 0u, 0u, 0u, 0u } },
> { WLAN_EID_HT_OPERATION, 0u, { 0u, 0u, 0u, 0u } },
> { WLAN_EID_HT_OPERATION, 0u, { 1u, 0u, 248u, 0u } },
> { WLAN_EID_HT_OPERATION, 0u, { 2u, 0u, 235u, 0u } },
> { WLAN_EID_HT_OPERATION, 0u, { 5u, 0u, 253u, 0u } },
> { WLAN_EID_PWR_CONSTRAINT, 0u, { 0u, 0u, 0u, 0u } },
> { WLAN_EID_OPMODE_NOTIF, 0u, { 0u, 0u, 0u, 0u } }
> };
>
> Add in an equivalent filter set as present in the downstream Linux driver.
> For now omit the beacon filter "rem" command as downstream does not have an
> explicit call to that SMD command. The filter mask should only count when
> we are inside BMPS anyway.
>
> Replicating the downstream ability to program the filter table gives us
> scope to add and remove elements in future. For now though this patch
> makes the rote-copy of the downstream Linux beacon filter table, which we
> can tweak as desired from now on.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
> ---
> drivers/net/wireless/ath/wcn36xx/hal.h | 16 ++++
> drivers/net/wireless/ath/wcn36xx/main.c | 1 +
> drivers/net/wireless/ath/wcn36xx/smd.c | 104 ++++++++++++++++++++++++
> drivers/net/wireless/ath/wcn36xx/smd.h | 3 +
> 4 files changed, 124 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/hal.h b/drivers/net/wireless/ath/wcn36xx/hal.h
> index e9fec110721b5..3351aaf5140df 100644
> --- a/drivers/net/wireless/ath/wcn36xx/hal.h
> +++ b/drivers/net/wireless/ath/wcn36xx/hal.h
> @@ -3468,6 +3468,22 @@ struct beacon_filter_ie {
> u8 ref;
> } __packed;
>
> +/* Downstream values for the bitmask field */
> +#define WCN36XX_FILTER_CAPABILITY_MASK 0x73cf
> +#define WCN36XX_FILTER_IE_DS_CHANNEL_MASK 0x00
> +#define WCN36XX_FILTER_IE_ERP_FILTER_MASK 0xF8
> +#define WCN36XX_FILTER_IE_EDCA_FILTER_MASK 0xF0
> +#define WCN36XX_FILTER_IE_QOS_FILTER_MASK 0xF0
> +#define WCN36XX_FILTER_IE_CHANNEL_SWITCH_MASK 0x00
> +#define WCN36XX_FILTER_IE_HT_BYTE0_FILTER_MASK 0x00
> +#define WCN36XX_FILTER_IE_HT_BYTE1_FILTER_MASK 0xF8
> +#define WCN36XX_FILTER_IE_HT_BYTE2_FILTER_MASK 0xEB
> +#define WCN36XX_FILTER_IE_HT_BYTE5_FILTER_MASK 0xFD
> +#define WCN36XX_FILTER_IE_OPMODE_NOTIF_MASK 0x00
> +#define WCN36XX_FILTER_IE_VHTOP_CHWIDTH_MASK 0xFC
> +#define WCN36XX_FILTER_IE_RSN_MASK 0x00
> +#define WCN36XX_FILTER_IE_VENDOR_MASK 0x00
> +
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index b05d10f9f6005..e6ee14adbe0da 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> +/* Downstream values for the bitmask field */
> +#define WCN36XX_FILTER_CAPABILITY_MASK 0x73cf
> +#define WCN36XX_FILTER_IE_DS_CHANNEL_MASK 0x00
> +#define WCN36XX_FILTER_IE_ERP_FILTER_MASK 0xF8
> +#define WCN36XX_FILTER_IE_EDCA_FILTER_MASK 0xF0
> +#define WCN36XX_FILTER_IE_QOS_FILTER_MASK 0xF0
> +#define WCN36XX_FILTER_IE_CHANNEL_SWITCH_MASK 0x00
> +#define WCN36XX_FILTER_IE_HT_BYTE0_FILTER_MASK 0x00
> +#define WCN36XX_FILTER_IE_HT_BYTE1_FILTER_MASK 0xF8
> +#define WCN36XX_FILTER_IE_HT_BYTE2_FILTER_MASK 0xEB
> +#define WCN36XX_FILTER_IE_HT_BYTE5_FILTER_MASK 0xFD
> +#define WCN36XX_FILTER_IE_PWR_CONSTRAINT_MASK 0x00
> +#define WCN36XX_FILTER_IE_OPMODE_NOTIF_MASK 0x00
> +#define WCN36XX_FILTER_IE_VHTOP_CHWIDTH_MASK 0xFC
> +#define WCN36XX_FILTER_IE_RSN_MASK 0x00
> +#define WCN36XX_FILTER_IE_VENDOR_MASK 0x00
Well, I didn't mean to do that..
More information about the wcn36xx
mailing list