[PATCH v2 0/7] wcn36xx: Tidy up BSS/STA config

[Loic Poulain]

On Sat, 29 Aug 2020 at 05:38, Bryan O'Donoghue
<bryan.odonoghue at linaro.org> wrote:
>
> This series is three of a set of five to add support for wcn3680 at
> 802.11ac data-rates.
>
> Both the BSS and STA config paths have redundant/duplicate code and before
> adding more code to either it makes sense to reduce/reuse and functionally
> decompose as much as possible.
>
> While not strictly necessary to get the wcn3680/80211.ac functioning in
> this driver, it seems like a missed opportunity to leave the code as is.
>
> Lets reduce down before adding more.

It looks good to me.
Reviewed-by: Loic Poulain <loic.poulain at linaro.org>

Regards,
Loic


On Sat, 29 Aug 2020 at 05:38, Bryan O'Donoghue
<bryan.odonoghue at linaro.org> wrote:
>
> This series is three of a set of five to add support for wcn3680 at
> 802.11ac data-rates.
>
> Both the BSS and STA config paths have redundant/duplicate code and before
> adding more code to either it makes sense to reduce/reuse and functionally
> decompose as much as possible.
>
> While not strictly necessary to get the wcn3680/80211.ac functioning in
> this driver, it seems like a missed opportunity to leave the code as is.
>
> Lets reduce down before adding more.
>
> V2:
> - Adds a memset to wcn36xx_smd_config_bss_v1()
>   Since we are doing one less kzalloc() we need to make sure we clear
>   out the bss config.
>
> V1:
> https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t
>
> Bryan O'Donoghue (7):
>   wcn36xx: Functionally decompose wcn36xx_smd_config_sta()
>   wcn36xx: Move wcn36xx_smd_set_sta_params() inside
>     wcn36xx_smd_config_bss()
>   wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params()
>   wcn36xx: Add wcn36xx_smd_config_bss_v0
>   wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally
>   wcn36xx: Convert to using wcn36xx_smd_config_bss_v0()
>   wcn36xx: Remove dead code in wcn36xx_smd_config_bss()
>
>  drivers/net/wireless/ath/wcn36xx/smd.c | 416 ++++++++++++++-----------
>  1 file changed, 227 insertions(+), 189 deletions(-)
>
> --
> 2.27.0
>