[bug report] wcn36xx: Add hardware scan offload support

[Loic Poulain]

Hi Dan,

On 5 April 2018 at 12:53, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> Hello Loic Poulain,
>
> The patch 2f3bef4b247e: "wcn36xx: Add hardware scan offload support"
> from Dec 8, 2017, leads to the following static checker warning:
>
>         drivers/net/wireless/ath/wcn36xx/smd.c:2144 wcn36xx_smd_hw_scan_ind()
>         warn: missing break? reassigning 'scan_info.aborted'
>
> drivers/net/wireless/ath/wcn36xx/smd.c
>   2125  static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)
>   2126  {
>   2127          struct wcn36xx_hal_scan_offload_ind *rsp = buf;
>   2128          struct cfg80211_scan_info scan_info = {};
>   2129
>   2130          if (len != sizeof(*rsp)) {
>   2131                  wcn36xx_warn("Corrupted delete scan indication\n");
>   2132                  return -EIO;
>   2133          }
>   2134
>   2135          wcn36xx_dbg(WCN36XX_DBG_HAL, "scan indication (type %x)", rsp->type);
>   2136
>   2137          switch (rsp->type) {
>   2138          case WCN36XX_HAL_SCAN_IND_FAILED:
>   2139                  scan_info.aborted = true;
>
>
> This is a Smatch warning, but I think the latest GCC will complain about
> this as well and say we need a /* fall through */ comment here.  I'm not

Thanks for reporting this, I'm going to submit a patch.

Regards,
Loic