[PATCH v2] wcn36xx: Fix dynamic power saving

Loic Poulain loic.poulain at linaro.org
Tue Dec 12 05:17:27 PST 2017


Hi Kalle,

On 12 December 2017 at 13:40, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Kalle Valo <kvalo at qca.qualcomm.com> writes:
>
>> Loic Poulain <loic.poulain at linaro.org> writes:
>>
>>> Since driver does not report hardware dynamic power saving cap,
>>> this is up to the mac80211 to manage power saving timeout and
>>> state machine, using the ieee80211 config callback to report
>>> PS changes. This patch enables/disables PS mode according to
>>> the new configuration.
>>>
>>> Remove old behaviour enabling PS mode in a static way, this make
>>> the device unusable when power save is enabled since device is
>>> forced to PS regardless RX/TX traffic.
>>>
>>> Acked-by: Bjorn Andersson <bjorn.andersson at linaro.org>
>>> Signed-off-by: Loic Poulain <loic.poulain at linaro.org>
>>
>> A fixes line would be nice for backporters. I can add that but need the
>> commit id.
>
> Or maybe this actually isn't a regression? Then of course a fixes line
> is not needed.

Yes, not really a regression since the issue came with the driver
itself (8e84c258).

>
> Should I push this to v4.15 or v4.16, any preference?

4.15 would be great.

Thanks,
Loic



More information about the wcn36xx mailing list