[PATCH] wcn36xx: Fix dynamic power saving

Loic Poulain loic.poulain at linaro.org
Mon Dec 11 00:39:11 PST 2017


Hi Bjorn,

On 9 December 2017 at 01:45, Bjorn Andersson <bjorn.andersson at linaro.org> wrote:
>>               }
>>       }
>>
>> +     if (changed & IEEE80211_CONF_CHANGE_PS) {
>> +             list_for_each_entry(tmp, &wcn->vif_list, list) {
>> +                     vif = wcn36xx_priv_to_vif(tmp);
>> +                     if (hw->conf.flags & IEEE80211_CONF_PS) {
>> +                             if (vif->bss_conf.ps) /* ps allowed ? */
>> +                                     wcn36xx_pmc_enter_bmps_state(wcn, vif);
>> +                     } else {
>> +                             wcn36xx_pmc_exit_bmps_state(wcn, vif);
>
> During startup I get the error print from wcn36xx_pmc_exit_bmps_state()
> that we're not in BMPS state. There's no harm in this, but the error
> might concern people.
>
> How about we in addition to this, change the wcn36xx_err() to a
> wcn36xx_dbg(PMC...) ?

Thanks for reporting this, I assume mac80211 disable PS mode before enabling it
on timeout... It makes sense to avoid this error msg since balancing
is well managed
by this driver.

Regards,
Loic



More information about the wcn36xx mailing list