[PATCH 2/7] wcn36xx: get chip type from platform ops

yfw fengwei.yin at linaro.org
Tue May 26 00:09:49 PDT 2015


Hi Eugene,

在 2015/5/26 14:38, Eugene Krasnikov 写道:
>> +       if (wcn->ctrl_ops->get_chip_type)
>> +               wcn->chip_version = wcn->ctrl_ops->get_chip_type();
>> +       else
>> +               wcn->chip_version = wcn36xx_detect_chip_version(wcn);
>> +
>
> I kind of like the idea about get_chip_type. Shall we get rid of
> wcn36xx_detect_chip_version completely? Do not like the idea to decide
> which chip is this based on 11ac support.
>
If we want to get rid of wcn36xx_detect_chip_version, we need to make
sure all platforms have get_chip_type.

Or we force get_chip_type is must-have API just like Andy did?
>
>

-- 
Regards
Yin, Fengwei



More information about the wcn36xx mailing list