[PATCH 2/2] wcn36xx: fix the mesh STA for rejoin

Yeoh Chun-Yeow yeohchunyeow at gmail.com
Fri Mar 21 11:43:13 EDT 2014


>
>>               rcu_read_unlock();
>
> But this is a bit of a problem: the rcu_read_lock() is needed to
> protect the sta, but wcn36xx_smd_config_sta() takes a mutex.
> You aren't allowed to sleep inside rcu read critical sections.

Ok, got it. So it is make sense if rcu_read_unlock is called before
taking a mutex?

> Actually, this crops up several other places in the driver,
> not just in this patch.
>
> I feel like making the firmware connection monitor not do its
> thing in mesh mode, if possible, would be a better way forward
> than re-adding the STAs like this.

Agreed. If we can managed to turn this off and eliminating the QoS
Null frame generated by the firmware, it will be better.

----
Chun-Yeow



More information about the wcn36xx mailing list