[PATCH 1/2] wcn36xx: initialize skb_lock

Eugene Krasnikov k.eugene.e at gmail.com
Wed Mar 19 07:52:28 EDT 2014


Looks good to me.

2014-03-18 12:09 GMT+00:00 Bob Copeland <me at bobcopeland.com>:
> ctl->skb_lock is never initialized, a fact caught by lockdep.
>
> Signed-off-by: Bob Copeland <bob at cozybit.com>
> ---
>  dxe.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dxe.c b/dxe.c
> index 6825ad3..61f398b 100644
> --- a/dxe.c
> +++ b/dxe.c
> @@ -85,6 +85,7 @@ static int wcn36xx_dxe_allocate_ctl_block(struct wcn36xx_dxe_ch *ch)
>                 if (!cur_ctl)
>                         goto out_fail;
>
> +               spin_lock_init(&cur_ctl->skb_lock);
>                 cur_ctl->ctl_blk_order = i;
>                 if (i == 0) {
>                         ch->head_blk_ctl = cur_ctl;
> --
> 1.7.10.4
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx



-- 
Best regards,
Eugene



More information about the wcn36xx mailing list