[PATCH] wcn36xx: initiate TX BA sessions

[Eugene Krasnikov]

Alright, if we want to start ampdu from data path then we need to
optimize wcn36xx_tx_start_ampdu as much as possible. My suggestions is
to call wcn36xx_tx_start_ampdu from wcn36xx_set_tx_data where we know
that it's a data packets and there is a STA id. What do you think
about that?

2014-03-10 14:48 GMT+00:00 Bob Copeland <me at bobcopeland.com>:
> On Mon, Mar 10, 2014 at 09:11:01AM +0000, Eugene Krasnikov wrote:
>> I do not think calling wcn36xx_tx_start_ampdu from a DATA path is a
>> good idea. I would suggest to move it to a separate work. What do you
>> think?
>
> I can rework it to do so, but it's not quite as simple, e.g we would at
> least need to make sure the sta is still around, whereas in the tx path
> we know that it's still valid.
>
> I took a look at ieee80211_start_tx_ba_session() - it does an
> allocation, but that only happens the (hopefully rare) times we
> establish a session.  The actual work of sending frames etc goes
> on the iface work queue already.
>
> From a quick survey of existing users, it looks like ath9k htc
> does it directly in tx path, and every other driver does it from
> rate controller (tx status path).
>
> --
> Bob Copeland %% www.bobcopeland.com



-- 
Best regards,
Eugene