[PATCH 1/5] wcn36xx: initialize device defaults on start

[Bob Copeland]

On Tue, Mar 04, 2014 at 09:05:08AM +0000, Eugene Krasnikov wrote:
> I think we should have done this a long time ago! My only concern is
> that we set something that is not used like:
> +       WCN36XX_CFG_VAL(INFRA_STA_KEEP_ALIVE_PERIOD, 0),
> 
> But since we do not have access to firmware then we expect that this
> flag must be set.

Well, I didn't come up with a minimal necessary set -- I tried, but
after about the tenth compile it became monotonous, and also I'm
hitting an occasional crash in wlan_dxe_tx_frame() making testing
individual changes harder (said crash happens without any of my
patches).

It is probably fine to get rid of many of these.

What about the location of the struct definition and the initval
array?  Is it ok in smd.c or should it live elsewhere?

Here are some of the more questionable settings:

> > +       WCN36XX_CFG_VAL(TELE_BCN_TRANS_LI, 3),

Not really sure what any of these "TELE" beacon things are...

> > +       WCN36XX_CFG_VAL(BTC_EXECUTION_MODE, 0),

Bluetooth?  Do we care?

> > +       WCN36XX_CFG_VAL(WCNSS_API_VERSION, 17039618),

We should figure out exactly what this setting means.

> > +       WCN36XX_CFG_VAL(ENABLE_MC_ADDR_LIST, 0),

Disables mcast filtering?

-- 
Bob Copeland %% www.bobcopeland.com