[PATCH v2 13/16] wcn36xx: add wcn36xx.h

[Kalle Valo]

Joe Perches <joe at perches.com> writes:

> On Mon, 2013-09-02 at 17:15 +0300, Kalle Valo wrote:
>> Joe Perches <joe at perches.com> writes:
>> 
>> >> +#define wcn36xx_dbg(mask, fmt, arg...) do {			\
>> >> +	if (debug_mask & mask)					\
>> >> +		printk(KERN_DEBUG pr_fmt(fmt), ##arg);	\
>> >> +} while (0)
>> >
>> > And maybe this one using pr_debug so dynamic_debug
>> > can work too.
>> 
>> Please, no dynamic_debug. It's useless on a wifi driver.
>
> Why is that?

It's not really usable in practise, at least the last time I looked at
it. It's cumbersome to enable log messages based on their line numbers
and line numbers change so you can't really make any scripts to help
with that. And enabling log messages on the file level is sometimes too
much. So it would really need some sort of grouping feature with a
stable interface.

-- 
Kalle Valo