[PATCH 3/3] wcn36xx: fix smatch warning

Eugene Krasnikov k.eugene.e at gmail.com
Tue Oct 8 15:33:27 EDT 2013


smatch does not like the fact that return will be
executed after first loop iteration. The right way to
go is to notify mac80211 about missed beacon for
all vifs.

Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
 smd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/smd.c b/smd.c
index e8aed73..fcf8c77 100644
--- a/smd.c
+++ b/smd.c
@@ -1898,8 +1898,8 @@ static int wcn36xx_smd_missed_beacon_ind(struct wcn36xx *wcn,
 						 struct ieee80211_vif,
 						 drv_priv);
 			ieee80211_connection_loss(vif);
-			return 0;
 		}
+		return 0;
 	}
 
 	if (len != sizeof(*rsp)) {
-- 
1.8.1.2




More information about the wcn36xx mailing list