[PATCH] wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware

[Eugene Krasnikov]

Hi Luis,

I looked at your patch deeper and couple of questions appeared:

1) The first line in the function ath_regd_init will execute
container_of with "struct ath_common". Do not you think we can try to
access wrong memory area?

2) __ath_regd_init will try to access EEPROM or at least call
functions with eeprom related. It's a bit misleading because
wcn36xx is not using eeprom. If possible could you please explain what
is the connection between ath regd implementation and EEPROM?

On Mon, Oct 7, 2013 at 6:50 PM, Luis R. Rodriguez
<mcgrof at do-not-panic.com> wrote:
> On Sun, Oct 6, 2013 at 12:30 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>>> +static void wcn_reg_notifier(struct wiphy *wiphy,
>>> +                            struct regulatory_request *request)
>>> +{
>>
>> Function should be called wcn36xx_reg_notifier not wcn_reg_notifier.
>> Could you please change that?
>
> Feel free to make that change on your end :D
>
>   Luis



-- 
Best regards,
Eugene