[PATCH] Send probe as unicast in joining state
Kalle Valo
kvalo at qca.qualcomm.com
Wed May 29 01:52:35 EDT 2013
Eugene Krasnikov <k.eugene.e at gmail.com> writes:
> While joining mac will try to send direct probe in case mac
> never received any probes from AP. But mac instead of sending
> unicast probe will send broadcast probe because some APs do
> not answer to direct packet in unassociated state. And HW
> cannot send broadcast packets in joining state so trick it
> like we are sending unicast probe instead of broadcast.
>
> Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
Looks good to me. It's a hack, but I guess we don't have any better
solution for the time being.
A cosmetic comment still:
> + /*
> + * In joining state trick hardware that probe is sent as unicast even
> + * if address is broadcast.
> + */
> + if (wcn->is_joining && ieee80211_is_probe_req(mgmt->frame_control)) {
> + bcast = false;
> + }
Upstream coding style prefers not to use braces here.
--
Kalle Valo
More information about the wcn36xx
mailing list