[PATCH] Re allocate the RX DMA buffer to avoid skb conflict Handle all RX packets in the DMA ring buffer

YanBo dreamfly281 at gmail.com
Tue May 28 02:40:22 EDT 2013


On Tue, May 28, 2013 at 1:59 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>> The GFP_ATOMIC is need cause normally the rx skb reallocation is be
>> done on interrupt context, although currently it is
>> implemented on the work queue but is not very correctly, both the
>> interrupt register and skb unmap/refill should be implemented
>> in the interrupt  context as quickly as possible to avoid the hardware
>> DMA engine reuse the skb or stuck due to some register no be cleared.
>> I'll submit another patch to move them to interrupt context instead of
>> in bottom half.
>>
>
> You can move the code to wcn36xx_irq_rx_ready.

As you said the DEX is complex and hard to debug, and there patch has
been test by me and prove it work,
as move the time sensitive code to  wcn36xx_irq_rx_ready, I'll submit
another patch after verify it work well.
but will not include in this patch. what your opinion?
BR /Yanbo
>
> This patch is number one for me today so please send updated version
> so we can review it and get it merged today;) But we must be careful
> with DXE part because issues there are really hard to track.
>
> --
> Best regards,
> Eugene



More information about the wcn36xx mailing list