[PATCH] Re allocate the RX DMA buffer to avoid skb conflict Handle all RX packets in the DMA ring buffer

Eugene Krasnikov k.eugene.e at gmail.com
Mon May 27 14:15:07 EDT 2013


Could you please resend this patch in proper format using git send-email?

>> +       skb = alloc_skb(WCN36XX_PKT_SIZE, GFP_ATOMIC);
>> +        if (skb == NULL) {
>> +               return -ENOMEM;

DXE is rather complicated thing. Could you please add more comments
why do we need to allocate RX buffer after each received packet? Is
not that a bit excessive to allocated new buffer on data path? Can we
just preallocate buffers? Do we need to use GFP_ATOMIC?

>> +H2H_TEST_RX_TX = DMA2

Do we need this? it is not used anywhere.

>> +#define WCN36XX_DXE_CTRL_VALID_MASK (0x00000001)

what is the purpose to have just number in brackets?

>> +#define WCN36XX_DXE_REG_CSR_RESET              WCN36XX_DXE_MEM_REG + 0x00

suggest to have something like this: (WCN36XX_DXE_MEM_REG + 0x00)

--
Best regards,
Eugene



More information about the wcn36xx mailing list