[PATCH 07/10] hal: improve config_sta() debug messages

Kalle Valo kvalo at qca.qualcomm.com
Mon May 27 10:10:24 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>> +                   "hal config sta v1 action %d sta_index %d bssid_index %d bssid %pM type %d mac %pM aid %d",
>> +                   sta->action, sta->sta_index, sta->bssid_index,
>> +                   sta->bssid, sta->type, sta->mac, sta->aid);
>
> I suggest to run checkpatch.pl over every patch.

Did you? :) wcn36xx is nowhere near ready for running checkpatch, there
are style errors everywhere. I haven't even bothered to run checkpatch
yet.

But we can worry about checkpatch later, the driver is still in early
stages and there's no point nitpicking with style at this point.

> Line limit is 80. So could you please update this line to be less than
> 80 characters?:)

Yeah, but rule doesn't apply for log format strings. The upstream
preference is to not split log message format strings.

-- 
Kalle Valo



More information about the wcn36xx mailing list