[PATCH 06/10] txrx: improve debug messages

Kalle Valo kvalo at qca.qualcomm.com
Mon May 27 07:53:10 EDT 2013


Knowing sequence number makes it easier to match with sniffer logs.

Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
---
 main.c |    3 ++-
 txrx.c |   11 +++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/main.c b/main.c
index 128a676..56f059f 100644
--- a/main.c
+++ b/main.c
@@ -188,8 +188,9 @@ static void wcn36xx_tx(struct ieee80211_hw *hw,
 		is_multicast_ether_addr(mgmt->da);
 
 	wcn36xx_dbg(WCN36XX_DBG_TX,
-		    "tx skb %p len %d fc %02x %s %s",
+		    "tx skb %p len %d fc %04x sn %d %s %s",
 		    skb, skb->len, __le16_to_cpu(mgmt->frame_control),
+		    IEEE80211_SEQ_TO_SN(__le16_to_cpu(mgmt->seq_ctrl)),
 		    high ? "high" : "low", bcast ? "bcast" : "ucast");
 
 	wcn36xx_dbg_dump(WCN36XX_DBG_TX_DUMP, "", skb->data, skb->len);
diff --git a/txrx.c b/txrx.c
index a534125..6eab7a6 100644
--- a/txrx.c
+++ b/txrx.c
@@ -25,6 +25,7 @@ int  wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
 	struct ieee80211_rx_status status;
 	struct ieee80211_hdr *hdr;
 	struct wcn36xx_rx_bd * bd;
+	u16 fc, sn;
 
 	skb2 = skb_clone(skb, GFP_ATOMIC);
 	bd = (struct wcn36xx_rx_bd *)skb2->data;
@@ -44,13 +45,15 @@ int  wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
 	memcpy(skb2->cb, &status, sizeof(struct ieee80211_rx_status));
 
 	hdr = (struct ieee80211_hdr *) skb2->data;
+	fc = __le16_to_cpu(hdr->frame_control);
+	sn = IEEE80211_SEQ_TO_SN(__le16_to_cpu(hdr->seq_ctrl));
 
 	if (ieee80211_is_beacon(hdr->frame_control)) {
-		wcn36xx_dbg(WCN36XX_DBG_BEACON, "beacon skb %p len %d fc %02x",
-			    skb2, skb2->len, __le16_to_cpu(hdr->frame_control));
+		wcn36xx_dbg(WCN36XX_DBG_BEACON, "beacon skb %p len %d fc %04x sn %d",
+			    skb2, skb2->len, fc, sn);
 	} else {
-		wcn36xx_dbg(WCN36XX_DBG_RX, "rx skb %p len %d fc %02x",
-			    skb2, skb2->len, __le16_to_cpu(hdr->frame_control));
+		wcn36xx_dbg(WCN36XX_DBG_RX, "rx skb %p len %d fc %04x sn %d",
+			    skb2, skb2->len, fc, sn);
 	}
 
 	wcn36xx_dbg_dump(WCN36XX_DBG_RX_DUMP, "SKB <<< ",




More information about the wcn36xx mailing list