[PATCH] Store AID after association

Kalle Valo kvalo at qca.qualcomm.com
Fri May 24 08:08:55 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

> Mac80211 is associated after BSS_CHANGED_ASSOC.
> Store AID and use it everywhere.
>
> Also fix rewriting bssid in smd_config_bss function
> that caused config_sta to fail with error 5.
>
> Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>

Thanks, looks good to me.

> @@ -352,8 +360,6 @@ static const struct ieee80211_ops wcn36xx_ops = {
>  	.sw_scan_complete       = wcn36xx_sw_scan_complete,
>  	.bss_info_changed 	= wcn36xx_bss_info_changed,
>  	.set_rts_threshold	= wcn36xx_set_rts_threshold,
> -	.sta_add 		= wcn36xx_sta_add,
> -	.sta_remove	 	= wcn36xx_sta_remove,
>  };

BTW, once I get AP mode working I need to add these two back. But they
can be removed for now.

> @@ -624,7 +624,6 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, enum nl80211_iftype type,
>  	WARN_ON(is_zero_ether_addr(bssid));
>  
>  	memcpy(&bss->bssid, bssid, ETH_ALEN);
> -	memcpy(&bss->bssid, &wcn->addresses[0], ETH_ALEN);

Thanks for fixing my bug. I was supposed to delete the latter memcpy()
but obviously forgot :)

-- 
Kalle Valo



More information about the wcn36xx mailing list