[PATCH] Reinit the RX DMA buffer to avoid skb conflict, Handle all RX packets in the DMA ring buffer

Kalle Valo kvalo at qca.qualcomm.com
Fri May 24 03:33:41 EDT 2013


YanBo <dreamfly281 at gmail.com> writes:

> On Fri, May 24, 2013 at 3:24 PM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> YanBo <dreamfly281 at gmail.com> writes:
>>
>>> This patch is used to reallocation the rx skb buffer instead of clone
>>> it, cause if just clone the skb, the hardware may refill the skb
>>> buffer when the upper layer still ir. and this skb buffer is still in
>>> DMA mapping status, it should not be access by the CPU before unmap
>>> it.
>>>
>>> Another function of this patch is it will check every possible filled
>>> RX descriptor in the ring buffer and handle them at once, normally the
>>> hardware may fill more than one RX descriptors but just trigger one
>>> interrupt to reduce CPU interrupt load.
>>>
>>> (This patch is just for pre review cause it is just generated after
>>> rebased on the newest wcn36xx repo. I have tested it in the previous
>>> wcn36xx repo.  but still not verify it after rebase due to lack of
>>> time, welcome to get you feedback for this)
>>
>> The patch was severily whitspace damaged so it was pretty difficult to
>> review. I recommend using git send-email to submit patches, it usually
>> gets everything right.
>>
>
> Yes, seem the gmail wrapper some sentence automatic, any method to
> avoid this?

Yes, use 'git send-email' tool :)

http://morefedora.blogspot.fi/2009/02/configuring-git-send-email-to-use-gmail.html

-- 
Kalle Valo



More information about the wcn36xx mailing list