[PATCH 3/7] debug: use printk() instead pr_debug()

Kalle Valo kvalo at qca.qualcomm.com
Mon May 20 15:28:32 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>> But if you want to keep it, I'm not going to loose my sleep on it :)
>> Let's try to find a compromise.
>
> I agree completely that this is not something crucial so let’s just
> find a compromise:)
>
>> So if CONFIG_DYNAMIC_DEBUG is enabled user/developer needs to use both
>> debug_mask and dynamic debug interface to enable the messages, right?
>
> This is how it should work in case of CONFIG_DYNAMIC_DEBUG

Why? What prevents us to improve dynamic debug's bad interface?

> Dynamic debug is enabled by default. So all pr_debug == printk. So it
> is enough for user to enable only debug_mask. But in case user wants
> to disable some particular print he can do it using dynamic debug.

My experience was different. pr_debug() was printed only when I enabled
it through /sys/kernel/debug/dynamic_debug/ and by default it was
disabled. But I admit that I tested that only briefly.

-- 
Kalle Valo



More information about the wcn36xx mailing list