[PATCH] Implement remove_interface and stop functionality

Eugene Krasnikov k.eugene.e at gmail.com
Fri May 17 14:49:03 EDT 2013


> I would consider sending the index instead of using struct mac_address
> the type. Or just a u8* as we do with the bssids. It should be kept
> consistent at least I think, so I vote for u8*.

Agree, will change to u8 next spin.

>
>> +int wcn36xx_smd_delete_sta_self(struct wcn36xx *wcn, struct mac_address addr);
>>  int wcn36xx_smd_delete_sta(struct wcn36xx *wcn);
>
> Do we still need the wcn36xx_smd_delete_sta function now? Seems like
> it's replace with the new wcn36xx_smd_delete_sta_self?

Yes, it's two different function. Let me explain what _add_ functions
do to make it clear:
1) wcn36xx_smd_add_sta_self tells hardware: "Hardware, this is your
address 1:2:3:4:5:6".
2) wcn36xx_smd_add_sta tells hardware: "Hardware, now you are
connected to address 6:5:4:3:2:1"

Hope this explains why delete_sta and delete_sta_self is needed:)



More information about the wcn36xx mailing list