[PATCH 3/7] debug: use printk() instead pr_debug()

[Eugene Krasnikov]

Why not to use dynamic debug? it has more flexibility let's say i want
to enable or disable debugging only in specific function. How would
you do that with this implementation?

2013/5/16 Kalle Valo <kvalo at qca.qualcomm.com>:
> If CONFIG_DYNAMIC_DEBUG is enabled user would need
> to use both debug_mask and /sys/kernel/debug/dynamic_debug/
> to get debug logs. That's just confusing, it should be
> enough to use debug_mask module parameter.
>
> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
> ---
>  wcn36xx.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/wcn36xx.h b/wcn36xx.h
> index e0302d9..74145b7 100644
> --- a/wcn36xx.h
> +++ b/wcn36xx.h
> @@ -56,7 +56,7 @@ enum wcn36xx_debug_mask {
>
>  #define wcn36xx_dbg(mask, fmt, arg...)                 \
>         if (debug_mask & mask)                          \
> -               pr_debug(DRIVER_PREFIX fmt "\n", ##arg)
> +               printk(KERN_DEBUG DRIVER_PREFIX fmt "\n", ##arg)
>
>  #define wcn36xx_dbg_dump(mask, prefix_str, buf, len)           \
>         if (debug_mask & mask)                                  \
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx



-- 
Best regards,
Eugene