[PATCH] Configure dtim_period dynamicly

[Eugene Krasnikov]

Yes, you are right, eventually we will move all sta/vif related
parameters to related structures. We have already some of them in
place e.g. https://github.com/KrasnikovEugene/wcn36xx/blob/master/wcn36xx.h#L90

Also the whole bss_info_changed function must be reworked a bit.

2013/6/28 Olof Johansson <dev at skyshaper.net>:
> On Fri, Jun 28, 2013 at 10:29 AM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>> Before dtim period was hardcoded to 2. Change it dynamically
>> based on AP configuration.
>>
>> Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
>> @@ -116,6 +116,7 @@ struct wcn36xx {
>>         u16                     aid;
>>         struct wcn36xx_vif      *current_vif;
>>         u16                     beacon_interval;
>> +       u8                      dtim_period;
>>         enum ani_ed_type        encrypt_type;
>>         u8                      fw_revision;
>>         u8                      fw_version;
>
> The code itself looks ok so I got no comments there.
>
> But I'm getting concerned over the growing amount of sta/vif specific
> parameters we are storing in the wcn struct. I think
> aid/dtim/beacon_interval/is_joining etc should be moved to the sta or
> vif specfic areas we have reserved for this stuff. Or am I mistaken?
>
> Cheers
> --
> Olof



-- 
Best regards,
Eugene