[PATCH 1/3] Use WCN36XX_BD_RATE_CTRL for 5G band

Eugene Krasnikov k.eugene.e at gmail.com
Thu Jun 27 09:52:18 EDT 2013


Let's rework wcn36xx_fill_tx_bd when we are done with filling all BD
flags. We should also keep in mind that it's a data path so we need to
optimize it as much as possible.

2013/6/27 Pontus Fuchs <pontus.fuchs at gmail.com>:
> On 2013-06-18 14:33, Eugene Krasnikov wrote:
>>
>> For MGMT frames on 5G band use WCN36XX_BD_RATE_CTRL rate.
>> The same must be done in future for P2P interface.
>>
>
> [...]
>
>
>
>> +               if (ieee80211_is_mgmt(hdr->frame_control))
>> +                       bd->bd_rate = (wcn->band == IEEE80211_BAND_5GHZ) ?
>> +                               WCN36XX_BD_RATE_CTRL :
>> +                               WCN36XX_BD_RATE_MGMT;
>
>
> [...]
>
>
>>                 else if (ieee80211_is_mgmt(hdr->frame_control))
>> -                       bd->bd_rate = WCN36XX_BD_RATE_MGMT;
>> +                       bd->bd_rate = (wcn->band == IEEE80211_BAND_5GHZ) ?
>> +                               WCN36XX_BD_RATE_CTRL :
>> +                               WCN36XX_BD_RATE_MGMT;
>
>
> Same code in two places. I'd prefer to have the bd rate selection in a
> function instead.
>
> Cheers,
>
> Pontus
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx



-- 
Best regards,
Eugene



More information about the wcn36xx mailing list