[PATCH 1/2] Configure bss when encryption is set

[Eugene Krasnikov]

Thank you Olof for review. Good catches, will update patches.

2013/6/26 Olof Johansson <dev at skyshaper.net>:
> On Tue, Jun 25, 2013 at 5:10 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>
>> +       if (IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags) {
>> +               wcn36xx_smd_config_bss(wcn,
>> +                                      NL80211_IFTYPE_STATION,
>> +                                      sta->addr,
>> +                                      true,
>> +                                      wcn->beacon_interval);
>> +       }
> Wouldn't this be better suited in the SET_KEY case or should we
> execute this even when we remove keys?
>
>
>> @@ -869,6 +874,7 @@ static int __init wcn36xx_init(void)
>>         wcn->aid = 0;
>>         wcn->current_vif = NULL;
>>         wcn->is_joining = false;
>> +       wcn->encrypt_type = WCN36XX_HAL_ED_NONE;
>>         wcn->hw->wiphy->n_addresses = ARRAY_SIZE(wcn->addresses);
>>         wcn->hw->wiphy->addresses = wcn->addresses;
>>
>
> Isn't this unnecessary? It'll be set to 0 by the memset anyway? No use
> in cluttering the code with



-- 
Best regards,
Eugene