[PATCH 3/4] Fix connection to AP mode

Eugene Krasnikov k.eugene.e at gmail.com
Fri Jun 7 07:33:13 EDT 2013


I updated pull request on top of current master
https://github.com/KrasnikovEugene/wcn36xx/pull/49
Will send out patches later on.

2013/6/7 Kalle Valo <kvalo at qca.qualcomm.com>:
> Hi,
>
> it's a bit difficult to reply as you have removed all my comments out of
> context. But I'll try anyway.
>
> Eugene Krasnikov <k.eugene.e at gmail.com> writes:
>
>>> Do we really support and enable all those in firmware now? I'm worried
>>> that enabling all sort of features without testing them creates bugs
>>> which are not that easy to find.
>>
>> This flags were set just because supplicant wanted me to set them:)
>
> It sounds very wrong that we lie to wpasupplicant if it requires
> something from us. Most likely the problem is somewhere else.
>
>> I agree that we should not bring this in until we tested all HT
>> capabilities. This is just a workaround in case you want to try AP
>> mode.
>
> Yes, that's good. But let's not commit these quite yet.
>
>>> This would be good to have in patch 4 (the workaround patch).
>>
>> Will not be used at all since we have a patch from Pontus.
>
> Ok.
>
>>> Do we really support all these? I would prefer to enable only after we
>>> have verified that the offload is working.
>>
>> It's a workaround because supplicant wanted me to have these flags
>> set;) Will not bring this in until tested properly.
>
> Yeah, let's review these more.
>
> --
> Kalle Valo



-- 
Best regards,
Eugene



More information about the wcn36xx mailing list