[PATCH 2/4] Configure AP in correct order

[Eugene Krasnikov]

The thing is that mac80211 does NOT change BSS_CHANGED_AP_PROBE_RESP
flag after BSS_CHANGED_BEACON_ENABLED and FW crashes if driver does
not call wcn36xx_smd_update_proberesp_tmpl after
wcn36xx_smd_send_beacon. So this is more like a workaround for the FW
crash. Have you seen crash on you FW version? May be if i update to
the latest FW i do not need this patch.

2013/6/4 Kalle Valo <kvalo at qca.qualcomm.com>:
> Eugene Krasnikov <k.eugene.e at gmail.com> writes:
>
>> wcn36xx_smd_send_beacon and wcn36xx_smd_update_proberesp_tmpl
>> must be called in proper order otherwise it will cause FW crash.
>>
>> Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
>
> [...]
>
>> @@ -397,6 +397,11 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
>>
>>                       wcn36xx_smd_set_link_st(wcn, vif->addr, vif->addr,
>>                                               link_state);
>> +                     wcn36xx_smd_send_beacon(wcn, skb, tim_off, 0);
>> +
>> +                     skb2 = ieee80211_proberesp_get(hw, vif);
>> +                     wcn36xx_smd_update_proberesp_tmpl(wcn, skb2);
>> +
>
> A better fix would be to set
>
>     wcn_priv->hw->wiphy->flags |= WIPHY_FLAG_AP_PROBE_RESP_OFFLOAD;
>
> That way mac80211 will use BSS_CHANGED_AP_PROBE_RESP and we don't need
> to the extra call here. I just didn't enable that in commit
> 2253b03ff8896ea1 AP mode wasn't properly working at the time.
>
> --
> Kalle Valo



-- 
Best regards,
Eugene